Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34438: php v1.17 release #933

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

rustagir
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34438
Staging - https://preview-mongodbrustagir.gatsbyjs.io/drivers/DOCSP-34438-php-v1.17-compat/php-drivers/#compatibility

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@rustagir rustagir marked this pull request as ready for review November 15, 2023 20:43
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + 1 suggestion

@@ -18,6 +18,19 @@
- MongoDB 3.0
- MongoDB 2.6

* - ext + lib 1.17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: update line 34 to "ext + lib 1.16 to 1.17" instead

@@ -18,7 +18,7 @@
- MongoDB 3.0
- MongoDB 2.6

* - ext + lib 1.16
* - ext + lib 1.16 to 1.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that 1.16 and 1.17 have the same server compatibility.

This is the first use of a range of versions AFAIK, but I trust this formatting is consistent with what is done for other drivers. I'm also a bit surprised that this is the first case of multiple versions having the same server compatibility (unless that's not the case but it just would have been strange to present a range like this given the ext/lib versions were previously out of sync).

Copy link
Contributor Author

@rustagir rustagir Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've recently been displaying versions with the same compatibility like this to avoid tables from becoming large. Yes, in the future we can keep condensing the PHP compat when it is the same as prev versions, but the versions being out of sync made that too visually confusing.

@rustagir rustagir merged commit c251bb9 into mongodb:master Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants