-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-34438: php v1.17 release #933
DOCSP-34438: php v1.17 release #933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm + 1 suggestion
@@ -18,6 +18,19 @@ | |||
- MongoDB 3.0 | |||
- MongoDB 2.6 | |||
|
|||
* - ext + lib 1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: update line 34 to "ext + lib 1.16 to 1.17" instead
@@ -18,7 +18,7 @@ | |||
- MongoDB 3.0 | |||
- MongoDB 2.6 | |||
|
|||
* - ext + lib 1.16 | |||
* - ext + lib 1.16 to 1.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that 1.16 and 1.17 have the same server compatibility.
This is the first use of a range of versions AFAIK, but I trust this formatting is consistent with what is done for other drivers. I'm also a bit surprised that this is the first case of multiple versions having the same server compatibility (unless that's not the case but it just would have been strange to present a range like this given the ext/lib versions were previously out of sync).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've recently been displaying versions with the same compatibility like this to avoid tables from becoming large. Yes, in the future we can keep condensing the PHP compat when it is the same as prev versions, but the versions being out of sync made that too visually confusing.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-34438
Staging - https://preview-mongodbrustagir.gatsbyjs.io/drivers/DOCSP-34438-php-v1.17-compat/php-drivers/#compatibility
Self-Review Checklist