Black formatter #158
Closed
Black formatter #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add black command to style env rm flake8 outdated plugins
tox deps for flask<2.0 releases requires own old version of pallets libraries
|
Finaly had time to fix up CI issue. Turns out it was dependencies for flask < 2.0 version. Added them to tox.ini |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, @dcrosta!
I understand, it's may be too late for this PR, but I've found this library and I made a little project with it. I found this repo a little bit outdated, so I've decided to contribute.
I added black support in tox's env 'style', as you mentioned in issue #128
You said you want to keep your flake8 imports plugin ordering, but black
currently support the way it is already.
flake8 had only one conflict with current black: W503 rule, so I added it to ignore.
p.s. this is my first PR, so if you have something to fix up here, let me know!
p.p.s. If you don't mind, may be I can do next issue with mypy?
p.p.p.s. pymongo's current version 4.1.1, may be we can update flask_pymongo to support this version as well?