Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded MongoDB driver dependency to mongodb-driver-legacy 4.11.3 #1

Closed
wants to merge 1 commit into from

Conversation

jyemin
Copy link
Collaborator

@jyemin jyemin commented Aug 15, 2024

  • Use mongodb-driver-legacy since mongo-java-driver uber jar is not published as of 4.0.
  • Replace find modifiers, which were removed in 4.0, with calls to FindIterable methods
  • Remove support for $maxScan, which is no longer supported by MongoDB
  • Remove support for $explain. The only way to explain with the 4.x driver is by calling FindIterable#explain. We could do that, and then use SingleTupleIterator, but is it worth it? Is explain only supported by OGM as a native query?
  • Handle breaking changes in WriteConcern class
  • Handle breaking changes related to MongoCredential

One big issue is that I can't get the tests to all pass even on the main branch, so I can't tell if all these changes are correct. I'm also unsure how to test against, say, MongoDB 7.0.

@jyemin jyemin self-assigned this Aug 15, 2024
@Sanne
Copy link

Sanne commented Aug 16, 2024

Thanks! Looks very reasonable - but it seems CI jobs are no longer being triggered; I'll need to ask my team mates about it.

@jyemin
Copy link
Collaborator Author

jyemin commented Aug 16, 2024

it seems CI jobs are no longer being triggered; I'll need to ask my team mates about it.

@Sanne , maybe because this PR is against our fork? Happy to open it against https://github.com/hibernate/hibernate-ogm instead. I was holding off because I wanted it go through some review first from MongoDB driver engineers.

@Sanne
Copy link

Sanne commented Aug 16, 2024

@jyemin ah right I hadn't realized!
yes please, don't worry and feel free to send any PRs to the reference fork.

@jyemin
Copy link
Collaborator Author

jyemin commented Aug 16, 2024

Done: hibernate#1127

@jyemin jyemin closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants