sync_info format peer list #8978
Conversation
maogo
commented
Aug 21, 2023
maogo
commented
format peer list
maogo
force-pushed
the
sync_info-format
branch
from
393bf04
to
580c057
Compare
|
How does this formatting work with smaller screens (admitting I haven't looked at code too closely)? |
|
yeah, that depends upon the screen resolution and visible area of terminal . When the horizontal width is not enough that table won't display correctly. If i2p/tor address joined: |
|
It's temping to not allow the patch on that basis, interested to know what others think. |
|
could make it an option for the command or if commands can't get options, just a new command (one thats not included in the default output of help because well that thing is already cluttered). |
| tools::success_msg_writer() << "Downloading at " << current_download << " kB/s"; | ||
| if (res.next_needed_pruning_seed) | ||
| tools::success_msg_writer() << "Next needed pruning seed: " << res.next_needed_pruning_seed; | ||
|
|
||
| tools::success_msg_writer() << std::to_string(res.peers.size()) << " peers"; | ||
| tools::success_msg_writer() << "Remote Host Peer_ID State Prune_Seed Height DL kB/s, Queued Blocks / MB"; | ||
| std::string table_line = "+" + std::string(longest_host_width - 1,'-')+ "+" + std::string(20 - 1,'-') + "+" + std::string(20 - 1,'-') + "+" + std::string(15 - 1,'-') + "+" + std::string(15 - 1,'-') + "+" + std::string(15 - 1,'-') + "+" + std::string(15 - 1,'-') + "+" + std::string(15 - 1,'-') + "+"; |
There was a problem hiding this comment.
I find the style here quite brittle: To change a column width, you have to edit three separate lines, and they don't even use the same constant (first two are X, last one is X - 1). It'd be way easier to read, and less error-prone, to use a structured array/vector here (e.g. heading + width, where width defaults to size, and can be adjusted for columns with wide content, like remote host); such an approach would also make it much easier to wrap the table across lines to fit the terminal, if someone wanted.
|
Hard-code here is bad , A well-encapsulated class for reuse is a better way, I am not c++ guy , If someone wants to make a new PR that's better . |
