core_rpc_server: silence unused warnings #8965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnerd
approved these changes
Aug 1, 2023
selsta
reviewed
Oct 13, 2023
| @@ -2356,6 +2356,7 @@ namespace cryptonote | |||
| bool core_rpc_server::use_bootstrap_daemon_if_necessary(const invoke_http_mode &mode, const std::string &command_name, const typename COMMAND_TYPE::request& req, typename COMMAND_TYPE::response& res, bool &r) | |||
| { | |||
| res.untrusted = false; | |||
| r = false; | |||
There was a problem hiding this comment.
Can you write it like this? Or maybe add a comment that this is silencing an unused warning to avoid confusion.
Suggested change
| r = false; | |
| (void)r; |
There was a problem hiding this comment.
I wrote it like this since it's good code practice to initialize output parameters anyways, but I could be convinced otherwise
selsta
approved these changes
Oct 26, 2023
hinto-janai
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.