Pt 1020 Bugfix for ProcessShipmentSave (#101)

Co-authored-by: Ivan Pugach <[email protected]>
mondu-ai · Feb 15, 2024 · b5b4699 · b5b4699
1 parent 52d7848
commit b5b4699
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Plugin/ProcessShipmentSave.php b/Plugin/ProcessShipmentSave.php
@@ -52,7 +52,14 @@ public function afterSave(
         $shipment
     ) {
         $order = $shipment->getOrder();
-        $monduLog = $this->monduLogger->getLogCollection($order->getData('mondu_reference_id'));
+
+        $monduId = $order->getData('mondu_reference_id');
+
+        if(!$monduId) {
+            return $shipment;
+        }
+
+        $monduLog = $this->monduLogger->getLogCollection($monduId);
 
         if ($monduLog->getSkipShipObserver()) {
             $this->monduFileLogger
@@ -64,7 +71,6 @@ public function afterSave(
             return $shipment;
         }
 
-        $monduId = $order->getData('mondu_reference_id');
         $this->monduLogger->syncOrder($monduId);
 
         if (!$this->monduLogger->canShipOrder($monduId)) {

diff --git a/composer.json b/composer.json
@@ -2,7 +2,7 @@
   "name": "mondu_gmbh/magento2-payment",
   "description": "Mondu payment method for magento 2",
   "type": "magento2-module",
-  "version": "2.3.4-RC1",
+  "version": "2.3.4-RC2",
   "license": [
     "MIT"
   ],