Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add export for package json for trident toolkit #2667

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Add export for package json for trident toolkit #2667

merged 1 commit into from
Dec 19, 2024

Conversation

MosheZemah
Copy link
Contributor

@MosheZemah MosheZemah requested a review from a team as a code owner December 19, 2024 07:18
@MosheZemah MosheZemah requested a review from sahariko December 19, 2024 07:18
YossiSaadi
YossiSaadi reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have other way to access it?
it is included outside of the dist folder by default

@sahariko
Copy link
Contributor

don't we have other way to access it? it is included outside of the dist folder by default

As long as exports exists and it's not included there, no.

@MosheZemah MosheZemah enabled auto-merge (squash) December 19, 2024 08:04
@MosheZemah MosheZemah merged commit f14dbaf into master Dec 19, 2024
14 checks passed
@MosheZemah MosheZemah deleted the bug/moshe/export_pkg_json branch December 19, 2024 08:07
@MosheZemah MosheZemah self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YossiSaadi YossiSaadi YossiSaadi left review comments

@talkor talkor talkor approved these changes

@sahariko sahariko sahariko approved these changes

Assignees

@MosheZemah MosheZemah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MosheZemah @sahariko @talkor @YossiSaadi