fix(List): fix ListTitle getting focus on initialization #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
approved these changes
Dec 10, 2024
| @@ -29,7 +29,7 @@ exports[`List renders correctly with list items 1`] = ` | |||
| onFocus={[Function]} | |||
| onMouseEnter={[Function]} | |||
| role="option" | |||
| tabIndex={0} | |||
| tabIndex={-1} | |||
There was a problem hiding this comment.
the bug already existed in the snapshot?? that shows the amount of trust you can get from this kind of testing 😓
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
rivka-ungar
deleted the
list-listtitle-getting-focus-on-first-enter-8011242971
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/views/80492480/pulses/8011242971?userId=59970142