feat(Modal): modal improvements, add stories for main Modal and modal's layouts #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt without stealing focus
…thout removing scroll
…e seen on story's code
…Show Code from rendering above Modal
YossiSaadi
changed the title
YossiSaadi
changed the title
…orarily the new Modal from docs we need to hide the new Modal until we would release it
talkor
approved these changes
Dec 5, 2024
packages/core/src/components/ModalNew/layouts/ModalSideBySideLayout/__stories__/assets/index.ts
Outdated
Show resolved
Hide resolved
packages/core/src/components/ModalNew/layouts/ModalMediaLayout/__stories__/assets/index.ts
Outdated
Show resolved
Hide resolved
packages/core/src/components/ModalNew/Modal/__stories__/Modal.stories.helpers.tsx
Show resolved
Hide resolved
| <Button onClick={() => setShowMedium(true)}>Medium</Button> | ||
| <Button onClick={() => setShowLarge(true)}>Large</Button> | ||
| </Flex> | ||
| {createPortal( |
There was a problem hiding this comment.
Why aren't we using a portal in the Modal?
There was a problem hiding this comment.
will add it, created a task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/7920875908
https://monday.monday.com/boards/3532714909/pulses/7719052213