feat(Search): allow tracking Enter key press #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomitc
reviewed
Nov 20, 2024
| @@ -35,6 +35,7 @@ const Search = forwardRef( | |||
| onFocus, | |||
| onBlur, | |||
| onClear, | |||
| onEnterKey, | |||
There was a problem hiding this comment.
why aren't we just exposing onKeyDown?
There was a problem hiding this comment.
I actually thought about doing it, but maybe we should make this more straightforward for cases like Enter, which is the one the team currently needs. I can't think of another key that someone might want to check for stuff like Search field
There was a problem hiding this comment.
@shlomitc after reconsideration, went with your suggestion at the end, thanks!
leave the handling for the consumer
YossiSaadi
force-pushed
the
feat/yossi/search-allow-tracking-onenterkey-event-7890250116
branch
from
0aa8e80 to
626211e
Compare
talkor
approved these changes
Nov 21, 2024
YossiSaadi
deleted the
feat/yossi/search-allow-tracking-onenterkey-event-7890250116
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/7890250116