chore: add d.ts file compilation to testkit #2585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
changed the title
YossiSaadi
requested changes
Nov 13, 2024
packages/testkit/package.json
Outdated
| @@ -17,13 +27,14 @@ | |||
| }, | |||
| "scripts": { | |||
| "test:e2e": "npx playwright test", | |||
| "build": "tsc", | |||
| "build": "tsc && tsc --project tsconfig.esm.json", | |||
There was a problem hiding this comment.
is this for a different esm and cjs? why we need cjs?
There was a problem hiding this comment.
we have clients that use commonjs. i.e the monolith. So we need it for now.
There was a problem hiding this comment.
the monolith can use esm as far as I know
@talkor, does it did any trouble to you with @vibe/core when you used esm only?
There was a problem hiding this comment.
can you separate the cases? @uziab
have a release with esm only and add cjs if the need arises?
There was a problem hiding this comment.
Sorry no, The monolith e2e project can't handle esm, so we would need cjs.
There was a problem hiding this comment.
got ya, ok let's leave it for now and try to tackle it later on
YossiSaadi
reviewed
Nov 20, 2024
YossiSaadi
reviewed
Nov 20, 2024
YossiSaadi
reviewed
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #