Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icons): update icons #2583

Merged
merged 3 commits into from
Nov 10, 2024
Merged

fix(icons): update icons #2583

merged 3 commits into from
Nov 10, 2024

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar requested a review from a team as a code owner November 10, 2024 11:18
talkor
talkor reviewed Nov 10, 2024
View reviewed changes
Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to rebuild them?

@rivka-ungar
Copy link
Contributor Author

no need to rebuild them?

Oops you're right.

@talkor
Copy link
Member

talkor commented Nov 10, 2024

@rivka-ungar don't forget to update in the vibe3 branch as well

@rivka-ungar rivka-ungar merged commit 0d6803c into master Nov 10, 2024
10 of 11 checks passed
@rivka-ungar rivka-ungar deleted the icon-alignment-handoff-off-grid-icons-7677023586 branch November 10, 2024 12:53
YossiSaadi added a commit that referenced this pull request Nov 18, 2024
@YossiSaadi
fix(Switcher): revert icon change to older version
36b8092 
this reverts commit change 0d6803c from PR #2583
@YossiSaadi YossiSaadi mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talkor talkor talkor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivka-ungar @talkor