Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix upload artifacts job and try fixing test #2578

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

uziab
Copy link
Contributor

@uziab uziab commented Nov 5, 2024

Resolves #

@uziab uziab requested a review from a team as a code owner November 5, 2024 18:35
@uziab uziab requested review from talkor and rivka-ungar November 6, 2024 08:05
Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@@ -16,6 +16,6 @@ test.describe("dropdown Class with Storybook", () => {
test("set dropdown value", async ({page}) => {
await DropDown.selectItem("2");
await page.waitForTimeout(500);
expect(await DropDown.getText()).toContain("Option 2");
expect(await DropDown.getText()).toContain("2");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok that it has changed?

@talkor talkor merged commit d738a46 into master Nov 6, 2024
8 of 9 checks passed
@talkor talkor deleted the fix-upload-artifacts branch November 6, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants