Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: publish docs to v2 folder [merge to v2 branch] #2573

Merged
merged 4 commits into from
Nov 24, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Nov 4, 2024

https://monday.monday.com/boards/3532714909/pulses/7232428118

Before merging vibe3 branch we'll run storybook-publish action from this branch. This will deploy the vibe 2 docs to a v2 folder. In the vibe3 branch there will be a filter to avoid deleting this folder which will remain static. This PR will be merged to the v2 branch which will be created right before merging the vibe3 branch

@talkor talkor changed the title ci: publish docs to v2 folder [not to merge] ci: publish docs to v2 folder [merge to v2 branch] Nov 4, 2024
@talkor talkor marked this pull request as ready for review November 4, 2024 16:05
@talkor talkor requested a review from a team as a code owner November 4, 2024 16:05
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about when v3 would be in master?

nm, saw your PR description

@talkor talkor changed the base branch from master to version2 November 24, 2024 11:50
@talkor talkor merged commit f450f4c into version2 Nov 24, 2024
11 checks passed
@talkor talkor deleted the docs/v2-docs-publish branch November 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants