fix(testkit): add eslint, small fixes and add tslib

packages/testkit/BaseElement.ts

@@ -6,14 +6,14 @@ import { test, Page, Locator } from "@playwright/test";
 export class BaseElement {
   page : Page;
   locator : Locator;
-  elementReportName: String 
+  elementReportName: string 
   /**
    * Create a BaseElement.
    * @param {Object} page - The Playwright page object.
    * @param {Object} locator - The locator for the element.
    * @param {string} elementReportName - The name for reporting purposes.
    */
-  constructor(page: Page, locator: Locator, elementReportName: String) {
+  constructor(page: Page, locator: Locator, elementReportName: string) {
     this.page = page;
     this.locator = locator;
     this.elementReportName = elementReportName;
@@ -31,7 +31,7 @@ export class BaseElement {
    * Wait for the list elements to stabilize (i.e., the count of items remains constant for a specified duration).
    * @returns {Promise<void>}
    */
-  async waitForElementsGroup(locator: Locator, elementReportName: String): Promise<void>  {
+  async waitForElementsGroup(locator: Locator, elementReportName: string): Promise<void>  {
     await test.step(`Wait for ${elementReportName} items to stabilize`, async () => {
       let previousCount = 0;
       let stableCountTime = 0;
@@ -75,6 +75,7 @@ export class BaseElement {
       await this.locator.scrollIntoViewIfNeeded();
     });
   }
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   async getAttributeValue(attributeName: string, options: any = { timeout: 10000, pollInterval: 500 }) : Promise <string | null> {
     let attributeValue = null;
 

packages/testkit/__TESTS__/checkbox.spec.js

@@ -12,7 +12,7 @@ test.describe("menuButton Class with Storybook", () => {
     checkbox = new Checkbox(page, checkboxLocator, "Test checkbox button");
   });
 
-  test("set checkbox", async ({page}) => {
+  test("set checkbox", async () => {
     if (await checkbox.isChecked()){
         await checkbox.setChecked(false);
         expect(await checkbox.isChecked()).toBe(false);

packages/testkit/__TESTS__/textArea.spec.js

@@ -13,7 +13,7 @@ test.describe("textArea Class with Storybook", () => {
     textArea = new TextArea(page, textAreaLocator, "Test text field");
   });
 
-  test("set text in textarea", async ({page}) => {
+  test("set text in textarea", async () => {
     await textArea.setText("Test Text");
     expect(textArea.textAreaInput.locator).toHaveValue("Test Text");
   });

packages/testkit/__TESTS__/textfield.spec.js

@@ -13,7 +13,7 @@ test.describe("textArea Class with Storybook", () => {
     textField = new TextField(page, textfieldLocator, "Test text field");
   });
 
-  test("set text in text field", async ({page}) => {
+  test("set text in text field", async () => {
     await textField.setText("Test Text");
     await textField.exitEditMode();
     expect(textField.locator).toHaveValue("Test Text");

packages/testkit/buttons/MenuButton.ts

@@ -9,6 +9,7 @@ export class MenuButton extends Button {
   override locator: Locator;
   override elementReportName: string;
   button: Button;
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   menu: any; 
 
   /**
@@ -18,6 +19,7 @@ export class MenuButton extends Button {
    * @param {string} elementReportName - The name for reporting purposes.
    * @param {any} menuType - The type of menu associated with the button.
    */
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   constructor(page: Page, locator: Locator, elementReportName: string, menuType: any) {
     super(page, locator, elementReportName);
     this.page = page;

packages/testkit/eslint.config.js

@@ -0,0 +1,6 @@
+// eslint.config.js
+export default [
+  {
+    ignores: ["node_modules/", "dist/", "*.config.js", "*.spec.js"],
+  }
+];

packages/testkit/package.json

@@ -24,6 +24,11 @@
     "url": "https://github.com/mondaycom/vibe/issues"
   },
   "devDependencies": {
-    "@playwright/test": "1.45.3"
+    "@eslint/js": "^9.13.0",
+    "@playwright/test": "1.45.3",
+    "eslint": "^9.13.0",
+    "globals": "^15.11.0",
+    "tslib": "^2.8.0",
+    "typescript-eslint": "^8.12.2"
   }
 }