Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react select import since it is a commonJS module #2540

Closed
wants to merge 1 commit into from
Closed

Fix react select import since it is a commonJS module #2540

wants to merge 1 commit into from

Conversation

MosheZemah
Copy link
Contributor

@MosheZemah MosheZemah self-assigned this Oct 15, 2024
@MosheZemah MosheZemah requested a review from a team as a code owner October 15, 2024 06:51
@YossiSaadi
Copy link
Contributor

It sound like this can increase the bundle even more (and react-select is heavy anyway)
@talkor can you insert the moduled react select to vibe2 as well? Or Alternatively, @MosheZemah can you use vibe3.0?

@talkor
Copy link
Member

talkor commented Oct 15, 2024

It sound like this can increase the bundle even more (and react-select is heavy anyway) @talkor can you insert the moduled react select to vibe2 as well? Or Alternatively, @MosheZemah can you use vibe3.0?

We fixed it in the fork so this can be closed

@MosheZemah MosheZemah closed this Oct 15, 2024
@MosheZemah MosheZemah deleted the bug/moshe/fix_react_select branch October 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MosheZemah MosheZemah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MosheZemah @YossiSaadi @talkor