convert VirtualizedList stories helpers file to TS #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivka-ungar
previously requested changes
Oct 14, 2024
There was a problem hiding this comment.
Thanks @Piyush-Tilokani!
Please use existing type VirtualizedListItem instead of creating a new type
rivka-ungar
reviewed
Oct 14, 2024
packages/core/src/components/VirtualizedList/__stories__/VirtualizedList.stories.helpers.tsx
Outdated
Show resolved
Hide resolved
|
Updated in the latest commit |
talkor
reviewed
Oct 20, 2024
There was a problem hiding this comment.
Thank you @Piyush-Tilokani ! Let's just remove the redundant type as CI fails
| @@ -2,17 +2,19 @@ | |||
| import React from "react"; | |||
| import { Tip } from "vibe-storybook-components"; | |||
|
|
|||
| export const generateItems = (defaultItemSize = 30, itemsCount, layout) => { | |||
| const items = []; | |||
| export const generateItems = (defaultItemSize: number = 30, itemsCount: number, layout: string) => { | |||
There was a problem hiding this comment.
Please remove the type from defaultItemSize as it inferred from the default value
See CI check
There was a problem hiding this comment.
Made the change in the latest commit
please check if it is correct
talkor
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2514
Converted the
packages/core/src/components/VirtualizedList/__stories__/VirtualizedList.stories.helpers.jsfile to .tsxPlease review and merge
Do let me know if any corrections are required
Thank you