Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Convert use debounce event to ts #2512

Merged

Conversation

ahammadabdullah
Copy link
Contributor

@ahammadabdullah ahammadabdullah commented Oct 13, 2024

fixes: #2475
First of all imported the Debounce type definitions and added it accordingly. Added a onClick function because its mandatory in the type definition.
Run the test and passed all tests.

@ahammadabdullah ahammadabdullah requested a review from a team as a code owner October 13, 2024 10:44
@talkor
Copy link
Member

talkor commented Oct 13, 2024

Thanks @ahammadabdullah ! The fix looks great but the branch contains some unrelated commits and Prettier fails, could you please force push with a single commit?

@ahammadabdullah
Copy link
Contributor Author

Thanks @ahammadabdullah ! The fix looks great but the branch contains some unrelated commits and Prettier fails, could you please force push with a single commit?

yes please give me some time.

@ahammadabdullah ahammadabdullah force-pushed the convert-useDebounceEvent-to-ts branch from 01a67b2 to cda88e2 Compare October 13, 2024 15:41
@ahammadabdullah ahammadabdullah force-pushed the convert-useDebounceEvent-to-ts branch from cda88e2 to 9d5a870 Compare October 13, 2024 15:49
@ahammadabdullah
Copy link
Contributor Author

@talkor please check now. Im sorry for the mess. Im not good at advance git yet.

Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahammadabdullah ! Looks great!

@talkor talkor merged commit f6c2d07 into mondaycom:master Oct 13, 2024
4 checks passed
@talkor talkor changed the title Convert use debounce event to ts docs: Convert use debounce event to ts Oct 13, 2024
@ahammadabdullah ahammadabdullah deleted the convert-useDebounceEvent-to-ts branch October 13, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: convert useDebounceEvent stories file to TS
2 participants