docs: convert useListenFocusTriggers stories file to TS #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LastExileUA @virtser @doronbrikman @jasonbahl |
talkor
requested changes
Oct 13, 2024
There was a problem hiding this comment.
@LoayTarek5 thank you for this PR! Looks like there are two similar files and the previous one is missing in this changeset (which means it's not deleted). Let's add the deletion of the old file, and keep only the tsx file here
Thanks!
…ListenFocusTriggers.stories.ts delete the additional file
…ub.com:LoayTarek5/vibe into docs/useListenFocusTriggers-stories-file-to-TS
|
@LoayTarek5 there is still the old file :( |
…ListenFocusTriggers.stories.js deletion the old file
talkor
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Great @LoayTarek5 ! Just check out my 2 comments, probably unused code
packages/core/src/hooks/useListenFocusTriggers/__stories__/useListenFocusTriggers.stories.tsx
Outdated
Show resolved
Hide resolved
| @@ -35,4 +37,4 @@ export const Overview = { | |||
| }, | |||
|
|
|||
| name: "Overview" | |||
| }; | |||
| } as const; | |||
talkor
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Thank you @LoayTarek5 ! Looks good, please just run prettier on this file as the CI fails for the extra spaces in line 7
Thanks!
run prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the main changes made to convert the code to TypeScript:
Added type annotation for the text state: useState("-").
Specified the type for the ref: useRef(null).
Added type annotations for the event parameters in onFocusByMouse and onFocusByKeyboard: React.FocusEvent.
Added an empty interface RenderProps which can be extended later if needed.
Added as const to the Overview object to ensure type inference for its properties.
Resolves #2474