Add placeholder for custom svg icon for SSR [prerelease] #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
YossiSaadi
approved these changes
Oct 10, 2024
YossiSaadi
reviewed
Oct 10, 2024
| @@ -154,7 +154,6 @@ Snapshot Diff: | |||
| + <div | |||
| + class="typography primary start text text1Normal container" | |||
| + data-testid="modal-content" | |||
| + style="--text-clamp-lines: 1;" | |||
There was a problem hiding this comment.
seem like an unwanted change?
There was a problem hiding this comment.
I think it is ok - I've removed text-clamp if single ellipsis line
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/4400799549/pulses/7510834798