docs: change useHover stories file extension from js to tsx #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Thanks @PrzemyslawPolrolniczak!
Looks like the useHover needs to be typed to match the div element, just need to add useHover<HTMLDivElement>();
Could you please add?
talkor
changed the title
|
@talkor I've pushed the fix, it should be fine now |
No worries! Thank you! |
talkor
approved these changes
Oct 10, 2024
|
Resolves #2472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just changed file extension and I didn't had to touch any code. Everything is typed well by default
btw. sorry for shitty branch name, I've copied convention from others and didn't knew it will add prefix stuff automatically. Well, it's my 1st open source PR, so lesson learned