Fix ssr issues #2477
Merged
Fix ssr issues #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
|
A new prerelease version of this PR has been published! 🎉 To update Or with npm: |
YossiSaadi
approved these changes
Oct 10, 2024
| {/* eslint-disable-next-line jsx-a11y/click-events-have-key-events */} | ||
| const dialog = | ||
| isClient() && | ||
| ReactDOM.createPortal( |
There was a problem hiding this comment.
seem like you can remove this ReactDOM.createPortal from here
it calls createPortal at line 209 as well
at the current implementation it would not render the Modal at all when SSR
YossiSaadi
reviewed
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/4400799549/pulses/6799260682