Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add lazy load variation for each icon #2469

Merged
merged 2 commits into from
Oct 9, 2024
Merged

feat: Add lazy load variation for each icon #2469

merged 2 commits into from
Oct 9, 2024

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar commented Oct 9, 2024 •
edited
Loading

@rivka-ungar rivka-ungar requested a review from a team as a code owner October 9, 2024 13:00
YossiSaadi
YossiSaadi approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!
Can you attach the screenshots of the chunks diff to the PR description please?

@YossiSaadi
Copy link
Contributor

oh btw, shouldn't you add it to rollup as well?

@rivka-ungar
Copy link
Contributor Author

oh btw, shouldn't you add it to rollup as well?

Good catch! forgot to push it..

@rivka-ungar rivka-ungar merged commit 1f6300c into vibe3 Oct 9, 2024
10 checks passed
@rivka-ungar rivka-ungar deleted the vibes-icons-library-add-lazy-loaded-variation-for-each-tsx-7338833464 branch October 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YossiSaadi YossiSaadi YossiSaadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivka-ungar @YossiSaadi