feat(ModalFooter): basic modal footer #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat/yossi/modalfooterbase-component-to-act-as-a-base-for-advanced-7360692401
to
feat/yossi/new-modal-building-blocks-7359960492
October 9, 2024 11:39
An error occurred while trying to automatically change base from
feat/yossi/modalfooterbase-component-to-act-as-a-base-for-advanced-7360692401
to
feat/yossi/new-modal-building-blocks-7359960492
October 9, 2024 11:39
YossiSaadi
force-pushed
the
feat/yossi/new-modal-building-blocks-7359960492
branch
from
153d94f to
23b868f
Compare
YossiSaadi
changed the base branch from
feat/yossi/new-modal-building-blocks-7359960492
to
feat/yossi/new-modal-footers
YossiSaadi
force-pushed
the
feat/yossi/new-modal-basicfooter--7360991588
branch
from
e64b471 to
d355056
Compare
talkor
approved these changes
Oct 15, 2024
...ages/core/src/components/ModalNew/footers/ModalFooterBase/__tests__/ModalFooterBase.test.tsx
Show resolved
Hide resolved
packages/core/src/components/ModalNew/footers/ModalFooter/ModalFooter.module.scss
Show resolved
Hide resolved
YossiSaadi
merged commit 1d394ab
into
feat/yossi/new-modal-footers
9 of 10 checks passed
YossiSaadi
added a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModalFooter
renderSideActioncan be either of:https://monday.monday.com/boards/3532714909/pulses/7360991588