feat(ModalSideBySideLayout): side by side layout component for new Modal #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
force-pushed
the
feat/yossi/new-modal-basic-layout-7360987899
branch
from
1380247 to
4986654
Compare
YossiSaadi
force-pushed
the
feat/yossi/new-modal-sidebyside-layout-7360989345
branch
from
dba9e3b to
9d43dca
Compare
talkor
approved these changes
Oct 15, 2024
...core/src/components/ModalNew/layouts/ModalSideBySideLayout/ModalSideBySideLayout.module.scss
Show resolved
Hide resolved
| @@ -0,0 +1,8 @@ | |||
| .media { | |||
There was a problem hiding this comment.
What if it's an image? Will users need to adjust the size?
There was a problem hiding this comment.
if they need a specific change they can pass className, but it should behave well with either image/lottie/video
There was a problem hiding this comment.
I feel like the way it's being provided now promises more than that 😅
There was a problem hiding this comment.
got ya, will check with different scenarios
Base automatically changed from
feat/yossi/new-modal-basic-layout-7360987899
to
feat/yossi/new-modal-layouts
October 20, 2024 11:25
YossiSaadi
force-pushed
the
feat/yossi/new-modal-sidebyside-layout-7360989345
branch
from
917339d to
3ebfe5b
Compare
YossiSaadi
merged commit e0de82b
into
feat/yossi/new-modal-layouts
9 of 10 checks passed
YossiSaadi
deleted the
feat/yossi/new-modal-sidebyside-layout-7360989345
branch
YossiSaadi
added a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SideBySide layout
Usage example:
https://monday.monday.com/boards/3532714909/pulses/7360989345