feat(ModalBasicLayout): basic layout component for new Modal #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
changed the title
Base automatically changed from
feat/yossi/modalfooterbase-component-to-act-as-a-base-for-advanced-7360692401
to
feat/yossi/new-modal-building-blocks-7359960492
October 9, 2024 11:39
An error occurred while trying to automatically change base from
feat/yossi/modalfooterbase-component-to-act-as-a-base-for-advanced-7360692401
to
feat/yossi/new-modal-building-blocks-7359960492
October 9, 2024 11:39
YossiSaadi
force-pushed
the
feat/yossi/new-modal-building-blocks-7359960492
branch
from
153d94f to
23b868f
Compare
to avoid overlapping top actions with the title (it should stop `spacing-medium`px before the actions)
YossiSaadi
force-pushed
the
feat/yossi/new-modal-basic-layout-7360987899
branch
from
1380247 to
4986654
Compare
YossiSaadi
changed the base branch from
feat/yossi/new-modal-building-blocks-7359960492
to
feat/yossi/new-modal-layouts
talkor
approved these changes
Oct 15, 2024
packages/core/src/components/ModalNew/layouts/ModalBasicLayout/ModalBasicLayout.tsx
Show resolved
Hide resolved
| ref: React.ForwardedRef<HTMLDivElement> | ||
| ) => { | ||
| const [header, content] = React.Children.toArray(children); | ||
| const { contentScrolled } = useModal(); |
There was a problem hiding this comment.
I was wondering about that one, I always get wondering what is a better practice
There was a problem hiding this comment.
On base elements it should be as close to native attrs IMO, other than that - if it's not intuitive enough (like disabled) than it should imply the type
There was a problem hiding this comment.
not sure I'm following
There was a problem hiding this comment.
<Button disabled> vs <ModalAction isContentScrolled>
There was a problem hiding this comment.
got ya
will change then 🙏🏼
packages/core/src/components/ModalNew/layouts/ModalBasicLayout/ModalBasicLayout.tsx
Outdated
Show resolved
Hide resolved
…lled per to CR request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic layout
Usage example:
https://monday.monday.com/boards/3532714909/pulses/7360987899