chore(useClickableProps): Codemod for changing dataTestId to data-testid #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
changed the title
YossiSaadi
approved these changes
Sep 1, 2024
packages/codemod/transformations/core/v2-to-v3/use-clickable-props-hook-migration.ts
Outdated
Show resolved
Hide resolved
Comment on lines
13
to
20
| root | ||
| .find(j.CallExpression, { | ||
| callee: { | ||
| type: "Identifier", | ||
| name: "useClickableProps" | ||
| } | ||
| }) | ||
| .forEach(path => { |
There was a problem hiding this comment.
would using JSCodeshift's findVariableDeclarators(hookName) help here?
and then you can maybe find the ObjectExpression, with Property of key of { type: 'Identifier' and name: 'dataTestId }
something like:
findVariableDeclarators(hookName)
.find(ObjectExpression)
.find(Property, {
key: {
type: 'Identifier',
name: 'dataTestId',
}
})
this can save you all the code from line 21 to 28 I believe
the rest can be changed with iterating over the Collection been made with forEach on each path.
something like:
path.node.key = j.literal('data-testid');
those two can turn into a generic util for changing a Callee argument name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/views/80492480/pulses/7338211944