feat(Toast): improve animation #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
reviewed
Aug 28, 2024
packages/core/src/components/Toast/__stories__/Toast.stories.tsx
Outdated
Show resolved
Hide resolved
YossiSaadi
approved these changes
Sep 22, 2024
Comment on lines
+135
to
+142
| const recalculateElementWidth = useCallback((element: HTMLElement) => { | ||
| const prevWidth = element.style.width; | ||
| element.style.width = "auto"; | ||
| const endWidth = getComputedStyle(element).width; | ||
| element.style.width = prevWidth; | ||
| element.offsetWidth; // force repaint | ||
| element.style.width = endWidth; | ||
| }, []); |
There was a problem hiding this comment.
damn. how heavy is this one? how many times does it gets triggered?
There was a problem hiding this comment.
it is an 11 years article btw, 100% still relevant?
There was a problem hiding this comment.
Unfortunately yes, there's no way to animate width and max-width will apply only when the width increases
There was a problem hiding this comment.
It's only called once and when the text changes so I don't think it's heavy
Co-authored-by: Yossi Saadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/7111634626
https://monday.monday.com/boards/3532714909/pulses/7359815024