docs: fix type checking in storybook #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
commented
Aug 12, 2024
There was a problem hiding this comment.
@YossiSaadi I had to revert this change, there were serious type issues otherwise. Maybe we can find other solution but I'm also ok with how it is now
There was a problem hiding this comment.
Not sure I understand what exactly was reverted here 🫣
talkor
commented
Aug 12, 2024
Comment on lines
+18
to
+20
| backButtonProps: Partial<ButtonProps>; | ||
| nextButtonProps: Partial<ButtonProps>; | ||
| finishButtonProps: Partial<ButtonProps>; |
There was a problem hiding this comment.
I changed it in a different PR since Button's children is now mandatory but I think making it a Partial is a better solution instead of providing children: '' as it already have defaults
talkor
commented
Aug 12, 2024
YossiSaadi
reviewed
Aug 12, 2024
| @@ -39,6 +39,12 @@ const config: StorybookConfig = { | |||
| docs: { | |||
| autodocs: false | |||
| }, | |||
| typescript: { | |||
There was a problem hiding this comment.
It read that simple? 🤦🏻♂️
shaharzil
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/6272877557
For example:
It will also fail storybook build and prevent releasing corrupted versions