Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove enumPropNamesArray #2348

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Conversation

talkor
Copy link
Member

@talkor talkor commented Aug 11, 2024

No longer needed since we use types, the props table is now showing the types instead of enums
https://monday.monday.com/boards/3532714909/pulses/7213849746

@talkor talkor added the vibe3 Related to 3.0 major label Aug 11, 2024
@talkor talkor requested a review from a team as a code owner August 11, 2024 14:31
Copy link
Contributor

@rivka-ungar rivka-ungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much cleaner now!

Base automatically changed from vibe3-cleanup to vibe3 August 15, 2024 09:24
@talkor talkor merged commit b914d01 into vibe3 Aug 15, 2024
10 checks passed
@talkor talkor deleted the vibe3-remove-enumPropNamesArray branch August 15, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vibe3 Related to 3.0 major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants