Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Tabs): reset spacings #2312

Merged
merged 2 commits into from
Aug 5, 2024
Merged

feat(Tabs): reset spacings #2312

merged 2 commits into from
Aug 5, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Aug 4, 2024

@talkor talkor requested a review from a team as a code owner August 4, 2024 14:31
@talkor talkor added breaking change vibe3 Related to 3.0 major labels Aug 5, 2024
shaharzil
shaharzil reviewed Aug 5, 2024
View reviewed changes
packages/core/docs/vibe-3-changelog.md Outdated
## TextField
### Tabs

- Fixed spacings (removed default browser's margin/padding for ul,li elements)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use the word "reset" so it will be more clear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@talkor talkor requested a review from shaharzil August 5, 2024 12:15
@talkor talkor merged commit 33f4b85 into vibe3 Aug 5, 2024
10 checks passed
@talkor talkor deleted the vibe3-tabs-reset-css branch August 5, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaharzil shaharzil shaharzil approved these changes

Assignees
No one assigned
Labels
breaking change vibe3 Related to 3.0 major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talkor @shaharzil