Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TextField): deprecate enums #2302

Merged
merged 2 commits into from
Aug 4, 2024
Merged

chore(TextField): deprecate enums #2302

merged 2 commits into from
Aug 4, 2024

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar added breaking change vibe3 Related to 3.0 major labels Aug 4, 2024
@rivka-ungar rivka-ungar requested a review from a team as a code owner August 4, 2024 07:41
talkor
talkor approved these changes Aug 4, 2024
View reviewed changes
packages/core/src/components/TextField/TextField.types.ts Outdated
@@ -0,0 +1,14 @@
export type TextFieldTextType =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not too much trouble I think it would be better to be called TextFieldType, but not critical

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@rivka-ungar rivka-ungar merged commit 5bfd1b9 into vibe3 Aug 4, 2024
10 checks passed
@rivka-ungar rivka-ungar deleted the vibe3-enums-TextField-7021052006 branch August 4, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talkor talkor talkor approved these changes

Assignees
No one assigned
Labels
breaking change vibe3 Related to 3.0 major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivka-ungar @talkor