Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(SplitButton): remove dataTestId props from nested elements #2199

Merged
merged 4 commits into from
Jul 2, 2024
Merged

chore(SplitButton): remove dataTestId props from nested elements #2199

merged 4 commits into from
Jul 2, 2024

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar requested a review from a team as a code owner June 30, 2024 14:53
@YossiSaadi YossiSaadi force-pushed the vibe3 branch 2 times, most recently from eef274f to 7b7affe Compare June 30, 2024 15:49
talkor
talkor approved these changes Jul 1, 2024
View reviewed changes
packages/core/docs/vibe-3-changelog.md Outdated Show resolved Hide resolved
@rivka-ungar rivka-ungar merged commit ea9c9dc into vibe3 Jul 2, 2024
10 checks passed
@rivka-ungar rivka-ungar deleted the splitbutton-remove-nested-datatestid-6887639903 branch July 2, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talkor talkor talkor approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivka-ungar @talkor