remove old label animation #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
reviewed
Jun 30, 2024
| @@ -70,6 +70,7 @@ | |||
| ### Label | |||
|
|
|||
| - `wrapperClassName` -> `className` [codemod] | |||
| - Removed old animation | |||
There was a problem hiding this comment.
I'd rephrase "old" as "slide" or "rotate", to make it more clear
Plus I think we should specify the isAnimationDisabled prop that was removed
There was a problem hiding this comment.
I bet there's some redundant CSS also 😅
YossiSaadi
force-pushed
the
vibe3
branch
2 times, most recently
from
eef274f to
7b7affe
Compare
talkor
reviewed
Jul 3, 2024
| @@ -8,7 +8,6 @@ | |||
| @import "keyframes/pop/pop-in-elastic"; | |||
| @import "keyframes/pop/pop-in-elastic-bold"; | |||
| @import "keyframes/pop/pop-out-from-trigger"; | |||
| @import "keyframes/spin/spin-in-emphasized"; | |||
There was a problem hiding this comment.
We need to think about this, since it's a breaking change in style
talkor
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/6798811711