Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TextField): add a controlled variant #2180

Merged
merged 2 commits into from
Jun 26, 2024
Merged

feat(TextField): add a controlled variant #2180

merged 2 commits into from
Jun 26, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Jun 23, 2024

@talkor talkor requested a review from a team as a code owner June 23, 2024 14:09
YossiSaadi
YossiSaadi reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't understand why if something is controlled it shouldn't get the logic of debounce, etc.

packages/core/src/components/TextField/TextField.tsx Show resolved Hide resolved
YossiSaadi
YossiSaadi approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need, when instructing people to use this new controlled to let them know they lose some of the built in functionality as debounce

packages/core/src/components/TextField/TextField.tsx Outdated Show resolved Hide resolved
@talkor talkor merged commit 67489b3 into master Jun 26, 2024
10 checks passed
@talkor talkor deleted the feat/TextField/controlled branch June 26, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YossiSaadi YossiSaadi YossiSaadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talkor @YossiSaadi