Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codemods): init repo + codemod infra + codemod: change next import to regular import #2176

Conversation

YossiSaadi
Copy link
Contributor

  • initiating codemods package in the monorepo
  • initiating codemod writing infra (right now mainly for import handling)
  • add a codemod
    • change next import to regular import

@YossiSaadi YossiSaadi force-pushed the feat/yossi/Create-codemods-infrastructure-6798809703-6841644723 branch from 5b46ebf to 72ef5ad Compare June 21, 2024 08:10
Copy link
Contributor

@shlomitc shlomitc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment - I suggest providing a single codemod for vibe 2 =>3 migration instead of multiple ones.
It should be easier to run instead of maintaining and applying multiple ones

@YossiSaadi
Copy link
Contributor Author

As a general comment - I suggest providing a single codemod for vibe 2 =>3 migration instead of multiple ones.
It should be easier to run instead of maintaining and applying multiple ones

Yep, we're gonna have a single one at the end, but it's considered a best practice to separate everything to different ones, and supply the option to run all

Right now I'm preparing a single codemod for each "type" (prop change, prop removal, import handling, etc.) to have everyone in the team create similar codemods easily based on those

@YossiSaadi YossiSaadi force-pushed the feat/yossi/Create-codemods-infrastructure-6798809703-6841644723 branch from 72ef5ad to c312e7b Compare June 23, 2024 06:54
@YossiSaadi YossiSaadi marked this pull request as ready for review June 23, 2024 06:56
@YossiSaadi YossiSaadi requested a review from a team as a code owner June 23, 2024 06:56
@YossiSaadi YossiSaadi changed the title feat(codemods): init repo + codemod infra + codemod: change next import to regular import chore(codemods): init repo + codemod infra + codemod: change next import to regular import Jun 23, 2024
@YossiSaadi YossiSaadi force-pushed the vibe3 branch 2 times, most recently from eef274f to 7b7affe Compare June 30, 2024 15:49
@YossiSaadi YossiSaadi force-pushed the feat/yossi/Create-codemods-infrastructure-6798809703-6841644723 branch from c312e7b to 81a3280 Compare July 2, 2024 15:01
@YossiSaadi YossiSaadi closed this Jul 9, 2024
@YossiSaadi YossiSaadi deleted the feat/yossi/Create-codemods-infrastructure-6798809703-6841644723 branch September 22, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants