chore: warn deprecated props #2154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
as it is a hook, maybe the folder name should imply to it?
|
|
||
| type DeprecatedProps = Record<string, string>; | ||
|
|
||
| export function useWarnDeprecatedProps<T extends Record<string, any>>( |
There was a problem hiding this comment.
you made it generic but haven't used it as generic in any of the usages, is it needed?
|
|
||
| export function useWarnDeprecatedProps<T extends Record<string, any>>( | ||
| props: T, | ||
| deprecatedProps: DeprecatedProps, |
There was a problem hiding this comment.
maybe alternativeProps? or something similar? it implies for old props, not new one
| Object.keys(deprecatedProps).forEach(prop => { | ||
| if (prop in props && props[prop] !== undefined) { | ||
| console.warn( | ||
| `${componentName}: '${prop}' prop is deprecated and will be removed in the next major version. Use '${deprecatedProps[prop]}' instead. [monday-ui-react-core]` |
There was a problem hiding this comment.
Suggested change
| `${componentName}: '${prop}' prop is deprecated and will be removed in the next major version. Use '${deprecatedProps[prop]}' instead. [monday-ui-react-core]` | |
| `[monday-ui-react-core] ${componentName}: '${prop}' prop is deprecated and will be removed in the next major version. Use '${deprecatedProps[prop]}' instead.` |
Just a suggestion, for you to decide
|
Decided not to do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/6751163668