Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StatusTag): Add Alpha style #2136

Merged
merged 3 commits into from
May 23, 2024

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar commented May 22, 2024

@rivka-ungar rivka-ungar requested a review from a team as a code owner May 22, 2024 14:15
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems cool 💪🏻

@@ -4,7 +4,7 @@
padding: 0 var(--sb-spacing-small);
text-transform: capitalize;

&.beta {
&.alpha, &.beta {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want it with same style on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thats what it said in the task :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌🏻

@rivka-ungar rivka-ungar merged commit 118d83d into master May 23, 2024
10 checks passed
@rivka-ungar rivka-ungar deleted the Add-Alpha-style-to--StatusTag--5454353803 branch May 23, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants