feat: Ignore classes in useClickOutside hook #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
reviewed
May 26, 2024
Comment on lines
22
to
26
| if (ignoreClasses && event.target instanceof HTMLElement) { | ||
| if (event.target.closest(ignoreClasses.join(','))) { | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: avoid nested if statement, the condition can be extracted to a variable to simplify the statement
talkor
reviewed
May 26, 2024
packages/core/src/hooks/useClickOutside/__stories__/useClickOutside.mdx
Outdated
Show resolved
Hide resolved
talkor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support excluding classes when checking if a click occurred outside for useClickOutside hook.