-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(label): add small variant #2121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! See two minor comments, regarding types file and storybook decorators
packages/core/src/components/Label/__stories__/label.stories.tsx
Outdated
Show resolved
Hide resolved
…2676' into Label---Add-small-variant-6623032676
…2676' into Label---Add-small-variant-6623032676
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Let's just export the LabelProps interface
@@ -18,6 +21,21 @@ export default { | |||
decorators: metaSettings.decorators | |||
}; | |||
|
|||
const withGrid: Decorator = Story => ( | |||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! We want to extract these to storybook layout components and use them all over
|
||
export const Colors = { | ||
render: () => ( | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so much leaner now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
https://monday.monday.com/boards/3532714909/pulses/6623032676