Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(label): add small variant #2121

Merged
merged 13 commits into from
May 19, 2024
Merged

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar commented May 15, 2024

@rivka-ungar rivka-ungar requested a review from a team as a code owner May 15, 2024 08:45
Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! See two minor comments, regarding types file and storybook decorators

packages/core/src/components/Label/Label.tsx Outdated Show resolved Hide resolved
packages/core/src/components/Label/Label.tsx Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's just export the LabelProps interface

@@ -18,6 +21,21 @@ export default {
decorators: metaSettings.decorators
};

const withGrid: Decorator = Story => (
<div
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! We want to extract these to storybook layout components and use them all over


export const Colors = {
render: () => (
<>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much leaner now

Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rivka-ungar rivka-ungar merged commit 2ca6562 into master May 19, 2024
9 of 10 checks passed
@rivka-ungar rivka-ungar deleted the Label---Add-small-variant-6623032676 branch May 19, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants