Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(AlertBanner): replace Button & Icon with IconButton #2120

Merged
merged 6 commits into from
May 16, 2024
Merged

fix(AlertBanner): replace Button & Icon with IconButton #2120

merged 6 commits into from
May 16, 2024

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar requested a review from a team as a code owner May 12, 2024 13:17
talkor
talkor approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

packages/core/src/components/AlertBanner/AlertBanner.tsx Outdated Show resolved Hide resolved
@talkor
Copy link
Member

talkor commented May 15, 2024

Resolves #2084

@rivka-ungar rivka-ungar merged commit ee2d11c into master May 16, 2024
10 checks passed
@rivka-ungar rivka-ungar deleted the AlertBanner--replace-Button--Icon-with-IconButton-5414954008 branch May 16, 2024 08:55
@YossiSaadi YossiSaadi mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talkor talkor talkor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rivka-ungar @talkor