Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fea: add TextArea component #2107

Merged
merged 8 commits into from
May 7, 2024
Merged

fea: add TextArea component #2107

merged 8 commits into from
May 7, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented May 6, 2024

@talkor talkor requested a review from a team as a code owner May 6, 2024 14:19
YossiSaadi
YossiSaadi reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work man, finally we have that in our DS 💪🏼

packages/core/setupTests.ts Outdated Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.tsx Outdated Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.tsx Outdated Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.tsx Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.tsx Outdated Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.tsx Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.tsx Outdated Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.module.scss Outdated Show resolved Hide resolved
packages/core/src/components/TextArea/TextArea.module.scss Show resolved Hide resolved
packages/core/src/components/TextArea/__tests__/TextArea.test.js Show resolved Hide resolved
YossiSaadi
YossiSaadi approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@talkor talkor merged commit 4764a86 into master May 7, 2024
10 checks passed
@talkor talkor deleted the feat/text-area branch May 7, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YossiSaadi YossiSaadi YossiSaadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@talkor @YossiSaadi