refactor(MenuItem): separate MenuIcon logic from MenuItem #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is true or false
…und color if not specified
talkor
approved these changes
May 5, 2024
| border-radius: var(--spacing-xs); | ||
|
|
||
| &.disabled { | ||
| opacity: 0.4; |
There was a problem hiding this comment.
I know it matches the old style but how does it look with the disabled token?
There was a problem hiding this comment.
exactly the same as before (chromatic did not find any change)
There was a problem hiding this comment.
No I mean if you replace the opacity with the disabled token
There was a problem hiding this comment.
I think we have opacity here because of icons and other rendered stuff in the menu item, no?
Base automatically changed from
refactor/yossi/Break-MenuItem-to-smaller-pieces---SubMenuIcon-6566973814
to
MenuItem-Section-refactor---create-a-base-component-to-be-used-by-custom-implementations-6359753142
May 5, 2024 12:45
…be-used-by-custom-implementations-6359753142' into refactor/yossi/Break-MenuItem-to-smaller-pieces---MenuIcon-6580749432
YossiSaadi
merged commit c2dec4a
into
MenuItem-Section-refactor---create-a-base-component-to-be-used-by-custom-implementations-6359753142
10 checks passed
YossiSaadi
deleted the
refactor/yossi/Break-MenuItem-to-smaller-pieces---MenuIcon-6580749432
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532715121/pulses/6580749432