refactor(MenuItem): separate SubMenuIcon logic from MenuItem #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
approved these changes
May 5, 2024
packages/core/src/components/Menu/MenuItem/__stories__/MenuItem.stories.tsx
Show resolved
Hide resolved
| parameters: { | ||
| docs: { | ||
| liveEdit: { | ||
| scope: { Activity } |
There was a problem hiding this comment.
<MenuItem title="SVG icon" icon={Activity} />
I need to add this icon to the scope
otherwise it will only know what is VibeIcons.Activity, but the story says Activity
.../src/components/Menu/MenuItem/components/MenuItemSubMenuIcon/MenuItemSubMenuIcon.module.scss
Show resolved
Hide resolved
...ore/src/components/Menu/MenuItem/components/MenuItemSubMenuIcon/MenuItemSubMenuIcon.types.ts
Show resolved
Hide resolved
...mponents/Menu/MenuItem/components/MenuItemSubMenuIcon/__tests__/MenuItemSubMenuIcon.jest.tsx
Show resolved
Hide resolved
YossiSaadi
changed the base branch from
master
to
MenuItem-Section-refactor---create-a-base-component-to-be-used-by-custom-implementations-6359753142
YossiSaadi
merged commit 7ea79e3
into
MenuItem-Section-refactor---create-a-base-component-to-be-used-by-custom-implementations-6359753142
10 checks passed
YossiSaadi
deleted the
refactor/yossi/Break-MenuItem-to-smaller-pieces---SubMenuIcon-6566973814
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532715121/pulses/6566973814