Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text): Add new 12px font size (Text3) #2072

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Conversation

shaharzil
Copy link
Contributor

@shaharzil shaharzil requested a review from a team as a code owner April 16, 2024 15:01
Copy link
Member

@talkor talkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This is text2 normal
</Text>
</Flex>
<Flex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We said that we're gonna support bold but not document it, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to disable it typescript-wise?
and to not allow the mixin variants for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't want to block them so it won't look like a bug. we will just guide them to use It right (in Figma)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got ya 👍🏼

@shaharzil shaharzil merged commit cd4af2f into master Apr 17, 2024
9 of 10 checks passed
@shaharzil shaharzil deleted the add-12px-size-text branch April 17, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants