feat(Search): new Search component

[YossiSaadi]

https://monday.monday.com/boards/3532714909/pulses/6249458445

[talkor]

Looks really good! See comments

[talkor]

WDYT about giving a single prop for these? e.g. clearIcon: SubIcon
And I wonder if we should allow changing the searchIcon, it can be done in the TextField, why do we need it in both components?

[YossiSaadi]

in TextField the icon is not on the left, here you can have both icons simultaneously.
you have a good point since design also asked if we can avoid it
the thing is that we have cases where people changed the search icon and clear icon

and not sure about the single prop? I need to be able to pass label (as people would probably want to translate the label)

[talkor]

I mean clearIcon={<Icon icon={Clear} aria-label="clear" />} and not sure if possible but we can use the SubIcon type but making the aria-label required in this case.
Plus if designers don't want it and we don't want to support it we can decide here to avoid it

[YossiSaadi]

It should be an IconButton, though
and it can add complexity
in my best scenario it is removed, but it might be used by current consumers, making it require codemod and to remove ability

[talkor]

I don't think codemod should prevent us from doing anything
You can use a render prop (e.g. renderClearIcon and provide props like we did in some other component. Just think about a case where users will want to add a onClearIconClick to trigger analytics for example, you'll have to add a prop for it