feat: add autoFocus to CheckBox #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
reviewed
Apr 10, 2024
| @@ -122,7 +134,8 @@ describe("Checkbox tests", () => { | |||
| option1Value, | |||
| checkbox1Name, | |||
| checkbox2Name, | |||
| checkbox3Name | |||
| checkbox3Name, | |||
| defaultChecked: true | |||
There was a problem hiding this comment.
In the existing tests, the tests had defaultChecked set to true, I needed it to be false in my tests so I can check the autoFocus so I added this as optional
talkor
reviewed
Apr 10, 2024
| @@ -39,6 +40,8 @@ type RenderHelper = { | |||
| option3Text: string; | |||
| option3Value: string; | |||
| onChangeMock3: jest.MockedFunction<MockedFunction>; | |||
| defaultChecked?: boolean; | |||
| autoFocusOption2?: boolean; | |||
There was a problem hiding this comment.
:D, I can send just autoFocus and put it on the first option but I'm not sure it will be clear from outside.. WDYT?
YossiSaadi
reviewed
Apr 11, 2024
packages/core/src/components/Checkbox/__tests__/checkbox-tests.jest.tsx
Outdated
Show resolved
Hide resolved
YossiSaadi
approved these changes
Apr 11, 2024
YossiSaadi
reviewed
Apr 11, 2024
packages/core/src/components/Checkbox/__tests__/checkbox-tests.jest.tsx
Outdated
Show resolved
Hide resolved
….jest.tsx Co-authored-by: Yossi Saadi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new hard signup we want to autofocus the first option for each question in order to support accessibility and voice reading in the future: see -> task item
So for this reason, I added autoFocus prop to CheckBox