docs: add edit mode for stories in docs page #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that includes a live editor
…corator, add custom padding
… to scope of live edit
prettier fails because the parsing method at withLiveEdit is currently not generic enough
talkor
approved these changes
Apr 3, 2024
packages/core/src/storybook/components/canvas-wrapper/CanvasWrapper.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| const toggleCodeAction = useMemo( | ||
| () => ({ | ||
| title: "Toggle code editor", |
There was a problem hiding this comment.
Just like that? Play?
It opens and shut the live editor, not sure about Play
packages/core/src/storybook/components/canvas-wrapper/CanvasWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/storybook/decorators/withLiveEdit/withLiveEdit.tsx
Outdated
Show resolved
Hide resolved
| code={code} | ||
| theme={vscodeDark} | ||
| extensions={[langs.tsx()]} | ||
| style={{ fontSize: 13 }} |
There was a problem hiding this comment.
Yep, I want it to look same as Source, that's why I chose this theme and font size, to mimic as best as possible
YossiSaadi
deleted the
docs/yossi/Add-edit-mode-for-Storybooks-Docs-page-Stories-5898424178
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/5898424178
API:
scopecan be any component or helper function.so, it can be
someTextvar that is a stringand it can be a component
whatever which is a key-value obj that you want the react-live's preview to know
The only thing needs to be done to enable LiveEdit for an existing component is simply removing the Canvas import in the MDX
If you'd like to disable for specific story (e.g. the Overview story), just set in its CSF the
isEnabled: false