-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Tooltip): Rich tooltip #2040
Conversation
return ( | ||
<div className="monday-storybook-tooltip_positions"> | ||
<div> | ||
{/* The modifier's purpose is to prevent the tipseen from being displayed when the user scrolls the story upwards / downwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to find a way to clean up stories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean the section that is being rendered in the "source" area?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, because it's irrelevant for users who copy the code to use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LiveEdit should solve I believe
@@ -26,7 +26,7 @@ | |||
--sb-text-color-fixed-dark: #323338; | |||
--sb-inverted-color-background: #323338; | |||
--sb-disabled-background-color: #ecedf5; | |||
--sb-primary-background-hover-color: #dcdfec; | |||
--sb-primary-background-hover-color: rgba(103, 104, 121, 0.1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try to use Vibe for the storybook styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the intention was to avoid circular dependency with style when style had its own storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth opening a tech debt task for it? @talkor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sure will open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great! I'm just almost certain it is breaking one
...ages/core/src/components/Slider/__tests__/__snapshots__/slider-non-ranged-tests.jest.js.snap
Outdated
Show resolved
Hide resolved
@@ -26,7 +26,7 @@ | |||
--sb-text-color-fixed-dark: #323338; | |||
--sb-inverted-color-background: #323338; | |||
--sb-disabled-background-color: #ecedf5; | |||
--sb-primary-background-hover-color: #dcdfec; | |||
--sb-primary-background-hover-color: rgba(103, 104, 121, 0.1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the intention was to avoid circular dependency with style when style had its own storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work man 💪🏼
https://monday.monday.com/boards/3532714909/pulses/6203952469