Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tooltip): Rich tooltip #2040

Merged
merged 17 commits into from
Apr 3, 2024
Merged

feat(Tooltip): Rich tooltip #2040

merged 17 commits into from
Apr 3, 2024

Conversation

talkor
Copy link
Member

@talkor talkor commented Mar 28, 2024

@talkor talkor requested a review from a team as a code owner March 28, 2024 16:56
return (
<div className="monday-storybook-tooltip_positions">
<div>
{/* The modifier's purpose is to prevent the tipseen from being displayed when the user scrolls the story upwards / downwards.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find a way to clean up stories

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean the section that is being rendered in the "source" area?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, because it's irrelevant for users who copy the code to use it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LiveEdit should solve I believe

@@ -26,7 +26,7 @@
--sb-text-color-fixed-dark: #323338;
--sb-inverted-color-background: #323338;
--sb-disabled-background-color: #ecedf5;
--sb-primary-background-hover-color: #dcdfec;
--sb-primary-background-hover-color: rgba(103, 104, 121, 0.1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to use Vibe for the storybook styling

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the intention was to avoid circular dependency with style when style had its own storybook

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth opening a tech debt task for it? @talkor

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure will open

Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great! I'm just almost certain it is breaking one

packages/core/src/components/Text/Text.tsx Show resolved Hide resolved
@@ -26,7 +26,7 @@
--sb-text-color-fixed-dark: #323338;
--sb-inverted-color-background: #323338;
--sb-disabled-background-color: #ecedf5;
--sb-primary-background-hover-color: #dcdfec;
--sb-primary-background-hover-color: rgba(103, 104, 121, 0.1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the intention was to avoid circular dependency with style when style had its own storybook

packages/core/src/components/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
packages/core/src/components/Tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
@talkor talkor requested a review from YossiSaadi April 1, 2024 13:07
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work man 💪🏼

@talkor talkor merged commit dc0c470 into master Apr 3, 2024
10 checks passed
@talkor talkor deleted the feat/tooltip/rich-tooltip branch April 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants