feat(IconButton): loading state #2029
Conversation
| } | ||
|
|
||
| .loader.loader { |
There was a problem hiding this comment.
Why are we providing only a partial set of options? Let's give the ability to show the loader for all sizes, is it by design?
There was a problem hiding this comment.
It's showing for all of the sizes
We just need an override for the xxs size - 10 instead of 16
There was a problem hiding this comment.
Why do we need it anyway? Doesn't get a default size already in Loader?
There was a problem hiding this comment.
Can you nest instead of using the class twice? It will increase specificity
| height: 16px; |
There was a problem hiding this comment.
Which variables would you use here?
| display: block; | ||
| } |
There was a problem hiding this comment.
Why is it necessary? Is it inline by default?
There was a problem hiding this comment.
It's inline by default, yeah
Without display block it isn't displaying properly
| } | ||
|
|
||
| .loader.loader { |
There was a problem hiding this comment.
Can you nest instead of using the class twice? It will increase specificity
https://monday.monday.com/boards/3713040192/pulses/6317999430